Avoid blocking and panicking where possible#89
Closed
tnull wants to merge 3 commits intolightningdevkit:mainfrom
Closed
Avoid blocking and panicking where possible#89tnull wants to merge 3 commits intolightningdevkit:mainfrom
tnull wants to merge 3 commits intolightningdevkit:mainfrom
Conversation
Collaborator
Author
|
Draft since this needs further testing. |
tnull
force-pushed
the
2023-05-fix-blocking-sync
branch
from
6a7dc4a to
c803028
Compare
tnull
force-pushed
the
2023-05-fix-blocking-sync
branch
from
a36faa4 to
0e0f6ee
Compare
tnull
changed the title
block_on on our main runtime
Collaborator
Author
|
Closing for now, will open two separate PRs for this. |
joostjager
pushed a commit
to joostjager/ldk-node
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50
We avoid unwraps in a number of cases and switch some out for except.
Also, we had previously experienced cases where calling in via
sync_walletscould block the world. Here we avoid callingblock_onwhere possible to ensure we don't hit these cases anymore.