This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Further codebase modularization - #58
Merged
Merged
Conversation
tnull
marked this pull request as draft
December 6, 2023 14:10
Closed
tnull
force-pushed
the
2023-11-modularize-more
branch
from
December 6, 2023 14:15
7207a47 to
6b334df
Compare
Closed
tnull
force-pushed
the
2023-11-modularize-more
branch
from
December 6, 2023 14:18
6b334df to
b455817
Compare
tnull
force-pushed
the
2023-11-modularize-more
branch
4 times, most recently
from
December 7, 2023 15:22
16cf4f6 to
8d00528
Compare
Closed
Instead of re-exposing all relevant API calls on `LiquidityManager`, we simply expose them on the original message handlers and expose methods to retrieve those.
.. and move it to `lsps2/message_handler.rs`
.. and move it to `lsps1/message_handler.rs`
.. and move it to `lsps2/message_handler.rs`
.. and move it to `lsps1/message_handler.rs`
.. and `LSPS0MessageHandler` to `lsps0/message_handler.rs`
In parallel to LSPS2, we expose the internal `msgs`/`message_handler`/`event` modules of LSPS1. To this end, we add docs to all message types, mark docs in `event.rs` as TODO, and hide the public methods of LSPS1's message handler, as we'll want to expose-and-document them individually at a later date.
tnull
force-pushed
the
2023-11-modularize-more
branch
from
December 11, 2023 14:06
8feb063 to
6155dd4
Compare
tnull
marked this pull request as ready for review
December 11, 2023 14:06
Collaborator
Author
|
Now added most of the missing docs to LSPS1, exposed it in parallel to the structure now created in LSPS2, and enforcing docs to be present through CI. |
tnull
force-pushed
the
2023-11-modularize-more
branch
4 times, most recently
from
December 14, 2023 13:32
ee2593d to
a575030
Compare
tnull
force-pushed
the
2023-11-modularize-more
branch
from
December 14, 2023 13:41
a575030 to
24aa77e
Compare
tnull
force-pushed
the
2023-11-modularize-more
branch
from
December 15, 2023 09:12
f29b113 to
cdf1781
Compare
tnull
force-pushed
the
2023-11-modularize-more
branch
3 times, most recently
from
December 15, 2023 10:43
4dad3a3 to
5954efd
Compare
tnull
force-pushed
the
2023-11-modularize-more
branch
from
December 15, 2023 10:47
5954efd to
b7ca8e2
Compare
tnull
force-pushed
the
2023-11-modularize-more
branch
from
December 15, 2023 11:13
b7ca8e2 to
1f11274
Compare
johncantrell97
approved these changes
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #53.Closes #36.
Closes #17.
Closes #31.
Closes #68.
Supersedes #52.
We modularize the codebase further.