Shared ownership of NetworkGraph#1149
Merged
TheBlueMatt merged 2 commits intolightningdevkit:mainfrom Nov 1, 2021
Merged
Conversation
NetworkGraph is owned by NetGraphMsgHandler, but DefaultRouter requires a reference to it. Introduce shared ownership to NetGraphMsgHandler so that both can use the same NetworkGraph.
Since NetworkGraph has shared ownership, NetGraphMsgHandler does not need to expose its field.
Codecov Report
@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
+ Coverage 90.21% 90.46% +0.24%
==========================================
Files 70 70
Lines 36201 37946 +1745
==========================================
+ Hits 32660 34327 +1667
- Misses 3541 3619 +78
Continue to review full report at Codecov.
|
TheBlueMatt
approved these changes
Nov 1, 2021
valentinewallace
approved these changes
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkGraphis owned byNetGraphMsgHandler, butDefaultRouterrequires a reference to it. Introduce shared ownership toNetGraphMsgHandlerso that both can use the sameNetworkGraph. Removepubvisibility ofNetGraphMsgHandler's reference now that it doesn't have to be accessed in this manner.