Add public method to list pending monitor updates from ChainMonitor#1834
Merged
valentinewallace merged 1 commit intolightningdevkit:mainfrom Nov 9, 2022
Merged
Conversation
tnull
reviewed
Nov 7, 2022
wpaulino
previously approved these changes
Nov 7, 2022
tnull
previously approved these changes
Nov 8, 2022
valentinewallace
previously approved these changes
Nov 8, 2022
Contributor
valentinewallace
left a comment
There was a problem hiding this comment.
Feel free to squash!
b98967d
28695e0 to
b98967d
Compare
Codecov ReportBase: 90.80% // Head: 90.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1834 +/- ##
==========================================
- Coverage 90.80% 90.75% -0.06%
==========================================
Files 89 87 -2
Lines 47963 47389 -574
Branches 47963 47389 -574
==========================================
- Hits 43554 43008 -546
+ Misses 4409 4381 -28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TheBlueMatt
reviewed
Nov 8, 2022
b98967d to
ed14819
Compare
TheBlueMatt
previously approved these changes
Nov 8, 2022
valentinewallace
previously approved these changes
Nov 8, 2022
Collaborator
|
Users have requested the feature to list pending monitor updates from `ChainMonitor` so this adds that.
7f4ac0e
ed14819 to
7f4ac0e
Compare
tnull
approved these changes
Nov 9, 2022
valentinewallace
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users have requested the feature to list pending monitor updates from
ChainMonitorso this adds that.Closes #1786