Skip to content

looprpc: populate static address swap timing and cost fields#1150

Open
hieblmi wants to merge 1 commit into
lightninglabs:masterfrom
hieblmi:show-static-details
Open

looprpc: populate static address swap timing and cost fields#1150
hieblmi wants to merge 1 commit into
lightninglabs:masterfrom
hieblmi:show-static-details

Conversation

@hieblmi
Copy link
Copy Markdown
Collaborator

@hieblmi hieblmi commented May 29, 2026

  • Added initiation_time, last_update_time, cost_server, cost_onchain, and cost_offchain to StaticAddressLoopInSwap.
  • Populated static loop-in list responses with stored initiation/update timestamps.
  • Reported the persisted quoted swap fee as cost_server once the static loop-in invoice has been paid.
  • Left on-chain/off-chain costs at zero because static timeout-path miner fees are not currently persisted.
  • Added focused test coverage for static loop-in cost reporting behavior.

@hieblmi hieblmi requested a review from starius May 29, 2026 12:04
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the static address loop-in functionality by exposing timing and cost information through the RPC interface. By updating the protobuf definitions and implementing logic to calculate and report these metrics, users can now gain better visibility into the lifecycle and financial performance of their static address swaps.

Highlights

  • API Schema Updates: Extended the StaticAddressLoopInSwap RPC message to include initiation_time, last_update_time, cost_server, cost_onchain, and cost_offchain fields.
  • Cost Reporting Logic: Implemented staticAddressLoopInSwapCost to populate swap costs, ensuring server costs are reported once the invoice is paid, while keeping on-chain and off-chain costs at zero as they are not currently persisted.
  • Testing: Added comprehensive test coverage in TestStaticAddressLoopInSwapCost to verify the correct reporting of swap costs across different swap states.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds initiation time, last update time, and cost fields (server, on-chain, off-chain) to the StaticAddressLoopInSwap protobuf message and populates them in the server implementation. It also introduces a helper function to calculate these costs and adds corresponding unit tests. The review feedback correctly identifies a potential issue where calling UnixNano() on uninitialized time.Time fields can lead to unexpected negative timestamps, and suggests adding safety checks for zero-time values and nil pointers.

Comment thread loopd/swapclient_server.go Outdated
@hieblmi hieblmi force-pushed the show-static-details branch 2 times, most recently from 9848cff to 7aae14b Compare May 29, 2026 14:03
@hieblmi hieblmi force-pushed the show-static-details branch from 7aae14b to 1e5911c Compare May 29, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant