lncli: change listinvoices reversed flag to paginate-forwards#4003
Merged
Roasbeef merged 1 commit intoFeb 26, 2020
Merged
Conversation
guggero
approved these changes
Feb 14, 2020
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
LGTM 🥇
I think a boolean flag with default value true defeats the purpose of a flag. This makes more sense to me.
I'm fine with it being called differently on gRPC.
guggero
added
cli
carlaKC
approved these changes
Feb 18, 2020
Collaborator
carlaKC
left a comment
carlaKC
left a comment
There was a problem hiding this comment.
Looks good to me, I think it's fine having the rpc and cli have different values. This is much more intuitive, nice PR 🔥
bitromortac
force-pushed
the
listinvoices-reversed-flag
branch
from
ba5025d to
f47e34a
Compare
This commit renames the `reversed` pagination flag to `paginate-forwards`, which is off by default. In order to access older invoices one can set the paginate-forwards flag, which is more intuitive than setting the reversed flag to false.
bitromortac
force-pushed
the
listinvoices-reversed-flag
branch
from
f47e34a to
926d4ba
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The listinvoices
--reversedflag is changed to--paginate-forwardsto fix #3986.Currently, if one likes to start to paginate from the beginning of the invoices history
one has to set
--reversed=False, which is not very intuitive. Otherwise the--reversedflag has no effect at all, as it is set by default. The downside of the changeis that it diverts from the grpc API, where the reversed flag still is present.
If this change is wanted I would apply it also to the payments listing in PR #3960.