Update PHP_CodeSniffer repository link and schema URL#233
Update PHP_CodeSniffer repository link and schema URL#233rodrigoprimo wants to merge 1 commit intolightspeedwp:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughUpdated repository and schema references for PHP_CodeSniffer to point to new canonical locations. The XML configuration now references the official schema host instead of the GitHub raw content URL, and the README credits section links to the updated repository organisation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the PHP_CodeSniffer schema and repository URLs to their new official locations. A critical issue was identified in the composer.json file where duplicate require-dev and config sections will cause composer commands to fail, requiring these blocks to be merged.
| * [Gulp](https://gulpjs.com/) | ||
| * [Node.js](https://nodejs.org/) | ||
| * [PHP_CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) | ||
| * [PHP_CodeSniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) |
There was a problem hiding this comment.
The composer.json file is invalid because it contains duplicate keys (require-dev and config). This will cause composer commands to fail and must be fixed.
Please resolve this by merging the duplicate sections. For instance, the two require-dev blocks should be combined into one. When doing so, you'll need to choose the correct version for packages like wp-coding-standards/wpcs, which is specified with both ^3.0 and ^3.1.
PHP_CodeSniffer has moved to a new GitHub organization. The
squizlabs/PHP_CodeSnifferrepository is now archived and the project is actively maintained at https://github.com/PHPCSStandards/PHP_CodeSniffer.Additionally, PHP_CodeSniffer now provides a canonical permalink for the XML schema used in the
xsi:noNamespaceSchemaLocationattribute of ruleset files. This replaces the previousraw.githubusercontent.comURL with https://schema.phpcodesniffer.com/phpcs.xsd.See:
Summary by CodeRabbit
Release Notes