Skip to content

Lighting Regression since 2.0.0 #378

@BlueAmulet

Description

@BlueAmulet

Since lilToon 2.0.0, there seems to be some kind of lighting regression.

Image

I found that in openlit_core.hlsl, reverting the lightDirectionForSH9 change back to 1.10.3 makes the lighting more in line with the other shaders.

Image

2.3.2:

float3 GetV(float3 L, float3 positionWS)
{
    return
    #if defined(VRC_LIGHT_VOLUMES_INCLUDED)
    _UdonLightVolumeEnabled ? normalize(_WorldSpaceCameraPos.xyz - positionWS) :
    #endif
    L;
}

1.10.3:

lightDirectionForSH9 = sh9Dir + mainDir;
lightDirectionForSH9 = dot(lightDirectionForSH9,lightDirectionForSH9) < 0.000001 ? 0 : normalize(lightDirectionForSH9);

I've found a few other maps where the newer version of lilToon makes me too bright or too dark or differently colored compared to lilToon 1.10.3/poiyomi, but this map gives a good example of the difference:

Image

World in use here is MoonLit Wanderings

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions