Spinner widget

[futurepaul]

This is pretty basic except for the spinning math, which I wish I'd commented while I was writing it!

My layout strategy for this is to only match its container size if that container has a constrained height and width. Otherwise it uses the default widget height key to size itself. Does that sound reasonable?

[xStrom]

Looks promising!

[xStrom]

These two color methods should mention in their docs that the alpha channel is ignored.

[futurepaul]

Ah that was an oversight. Fixed it to use the color's alpha.

[xStrom]

Can't we use theme::LABEL_COLOR.into(), in the Default implementation?

[futurepaul]

Not sure what you're proposing here.

[xStrom]

So the reason you got that clippy warning was because the new function doesn't take any arguments and could be equal to default. So what I'm thinking is that we could do the following:

impl Spinner {
    /// Create a spinner widget
    pub fn new() -> Spinner {
        Spinner::default()
    }
}

impl Default for Spinner {
    fn default() -> Self {
        Spinner {
            t: 0.0,
            color: theme::LABEL_COLOR.into(),
        }
    }
}

It ends up being the same result for now, but if the new method gets arguments added to it then it'll be an easier change. This doesn't matter too much, but I'm just thinking I might somewhat prefer to have the default function be explicit.

Your call.

[futurepaul]

Ah, that makes sense! Thanks for explaining.

[xStrom]

I think it's in a good enough state to be merged.

[luleyleo]

Looks good.