Export Image and ImageData by default#1011
Merged
xStrom merged 9 commits intolinebender:masterfrom Jun 2, 2020
Merged
Conversation
This makes the `Image` widget and associated APIs more discoverable. There is also a note added that directs users on how to enable the "image" feature.
xStrom
reviewed
Jun 2, 2020
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
I think this is a good idea. Need to adjust some details though.
xStrom
added
S-needs-review
xStrom
approved these changes
Jun 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change exposes all of the
Imagefunctions andImageData::emptywithout exposing theimagecrate. it also shows hints about the "image" feature in the API docs.next
this PR doesn't add any functionality, really. still without the "image" feature enabled you can only draw an empty
Imagewidget, but this is just an incremental step toward a more robust API for this feature.i already have a bunch of documentation changes for
image.rs, but i wanted to push this change first (i'm also working on my git habits).