Standardize web terminology.#1013
Merged
xStrom merged 2 commits intolinebender:masterfrom Jun 2, 2020
Merged
Conversation
luleyleo
approved these changes
Jun 2, 2020
Collaborator
luleyleo
left a comment
luleyleo
left a comment
There was a problem hiding this comment.
Looks good, just one nitpick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR standardized the terminology when talking about targeting the web. The rationale for this change was discussed in #999.
Generally the term to use is
web. It's the web backend, and these apps are targeting the web. When going into more detail, WebAssembly (Wasm) can also come up as an implementation detail.I also renamed the
switchexample toswitchesso that it won't conflict with the reserved keyword in JavaScript.I also defined the default members of the workspace. This means that when you write
cargo clippyin the root workspace, it won't start also building all the web examples. You can still get that behavior withcargo clippy --workspaceand the CI will still test these.Fixes #999.