Supplement image widget docs#1018
Merged
xStrom merged 39 commits intolinebender:masterfrom Jun 20, 2020
Merged
Conversation
The idea is to work toward a more robust image widget. Documentation is just the first step.
By reducing the scope of the "image" feature, we can expose the bare-bones image widget API and better document the "image" feature.
This should make the feature more discoverable and make it clearer why it is optional.
xStrom
reviewed
Jun 5, 2020
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Thanks for working on improving the docs!
I made some inline comments how we can polish this even further.
druid/src/widget/image.rs
Outdated
Comment on lines
+33
to
+34
| /// Note: interpolation can lead to blurry or pixelated images and so is not | ||
| /// recommended for things like icons. Instead consider using |
Member
There was a problem hiding this comment.
Can lead to when? With DPI scaling? Should mention just briefly that when scaling.
Contributor
Author
There was a problem hiding this comment.
i'm not sure exactly how DPI scaling is relevant here? like images may look fine on a normal DPI screen but blurry when in hiDPI situations?
xStrom
added
S-waiting-on-author
xStrom
added
S-needs-review
The idea is to work toward a more robust image widget. Documentation is just the first step.
This should make the feature more discoverable and make it clearer why it is optional.
xStrom
approved these changes
Jun 20, 2020
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Sorry for letting this sit so long. Thanks for putting in the effort!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is mostly just a description of the existing API with a note about the "image" feature and more links.