added EditAction::SelectNone

[sysint64]

this PR adds a new edit action SelectNone as the opposite of SelectAll.

[cmyr]

Sorry for the delay!

I think this is equivalent to moving the selection to the start of the document, and that should be handled by a variant of MoveTo(); StartOfDocument or BeginningOfDocument should be one of the Movement variants.

If you'd like to update this with that change I would be happy to merge. :)

[sysint64]

@cmyr okay, I got it.

[cmyr]

@sysint64 ping on this?

[sysint64]

@cmyr I'm still here, just a lot of work, I'll work on my PR's on the following weekends.

[sysint64]

@cmyr does Movement::LeftOfLine do the same thing as should BeginningOfDocument? at least the current implementation seems to me to be what I have tried to do.

[cmyr]

It may be the same now, but it shouldn't be the same when we are handling multi-line text correctly; if it is that's likely a bug in the current implementation.

[sysint64]

@cmyr Sorry for the delay, I have implemented two methods - line_beginning and line_ending for EditableText, and added Movement::BeginningOfDocument and Movement::EndingOfDocument.

[cmyr]

Thanks! a few notes inline.

It's also worth mentioning that this won't currently work correctly when we have linebreaking implemented, but I think it's reasonable to merge anyway and we can worry about that later.

[sysint64]

@cmyr fixed.

[cmyr]

Okay apologies, I was a little brain dead during my previous review. There's still a naming issue here, and a larger issue with the naming of the movement types themselves. I'd like to at least get the naming correct here, and we can address the larger issue separately. Sorry for the run-around!

[sysint64]

@cmyr it looks like there is an error on the master branch located in druid/src/box_constraints.rs

[sysint64]

this is what I get after rebase:

error[E0428]: the name `tests` is defined multiple times
   --> druid/src/box_constraints.rs:375:1
    |
276 | mod tests {
    | --------- previous definition of the module `tests` here
...
375 | mod tests {
    | ^^^^^^^^^ `tests` redefined here
    |
    = note: `tests` must be defined only once in the type namespace of this module

[sysint64]

fixed here: #1187

[cmyr]

Thanks!