Allow derivation of lenses for generic types.#1120
Merged
cmyr merged 3 commits intolinebender:masterfrom Aug 11, 2020
Merged
Conversation
Types, lifetimes and where clauses covered plus interior type parameter name clashes.
rjwittams
force-pushed
the
derive-data-gen
branch
from
81975ab to
0d2463f
Compare
jneem
reviewed
Aug 9, 2020
CHANGELOG.md
Outdated
| - `LifeCycle::Size` event to inform widgets that their size changed. ([#953] by [@xStrom]) | ||
| - `Button::dynamic` constructor. ([#963] by [@totsteps]) | ||
| - `Spinner` widget to represent loading states. ([#1003] by [@futurepaul]) | ||
| - Allow derivation of lenses for generic types ([#1120]) by [@rjwittams]) |
Member
There was a problem hiding this comment.
This should be in the "Unreleased" section, not the "0.6.0" section
cmyr
approved these changes
Aug 10, 2020
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Haven't thought carefully about the possible edge cases, but this looks broadly good. There's one extraneous comment that is probably an accident, otherwise this looks good to me. Thanks!
druid-derive/src/lens.rs
Outdated
| Ident::new(&candidate, Span::call_site()) | ||
| }; | ||
|
|
||
| //let ret_ty_par = G; |
Collaborator
Author
There was a problem hiding this comment.
I'll get rid of that..
Member
|
Thanks @rjwittams & @jneem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types, lifetimes and where clauses covered plus interior type parameter name clashes.