Added BoxConstraints::UNBOUNDED#1126
Merged
luleyleo merged 3 commits intolinebender:masterfrom Aug 18, 2020
Merged
Conversation
Contributor
danieldulaney
commented
Aug 12, 2020
danieldulaney
commented
- BoxConstraints::UNBOUNDED is a constant that leaves the dimensions unconstrained
- Added tests confirming BoxConstraints::UNBOUNDED properties
* BoxConstraints::UNBOUNDED is a constant that leaves the dimensions unconstrained * Added tests confirming BoxConstraints::UNBOUNDED properties
danieldulaney
force-pushed
the
bc-unbounded
branch
from
9414501 to
73c3f46
Compare
richard-uk1
approved these changes
Aug 12, 2020
Collaborator
richard-uk1
left a comment
richard-uk1
left a comment
There was a problem hiding this comment.
Looks like a nice thing to have. I'll see what others say as well.
luleyleo
reviewed
Aug 17, 2020
Collaborator
luleyleo
left a comment
luleyleo
left a comment
There was a problem hiding this comment.
Seems reasonable, the changelog needs a fix though.
CHANGELOG.md
Outdated
| - Re-export `druid_shell::Scalable` under `druid` namespace. ([#1075] by [@ForLoveOfCats]) | ||
| - `TextBox` now supports ctrl and shift hotkeys. ([#1076] by [@vkahl]) | ||
| - Added selection text color to textbox. ([#1093] by [@sysint64]) | ||
| - Added `BoxConstraints::UNBOUNDED` constant. ([#1126] by [@danieldulaney]) |
Collaborator
There was a problem hiding this comment.
The links must be added manually, see CONTRIBUTING.md.
Also, the "Added" prefix in the previous entry should not be there, nor should this entry have one.
cmyr
approved these changes
Aug 17, 2020
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Looks good to me, I'll fixup the changelog and merge. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.