Don't make Scroll bigger than its child on the non-scrolling axis.#1198
Merged
jneem merged 1 commit intolinebender:masterfrom Sep 9, 2020
jneem:scroll-size
Merged
Don't make Scroll bigger than its child on the non-scrolling axis.#1198jneem merged 1 commit intolinebender:masterfrom jneem:scroll-size
jneem merged 1 commit intolinebender:masterfrom
jneem:scroll-size
Conversation
Collaborator
ForLoveOfCats
left a comment
ForLoveOfCats
left a comment
There was a problem hiding this comment.
Yep, this seems right and matches how the old Scroll calculated its size. If it needs to expand that's what SizeBox is for.
In my defense that patch went through a lot of iterations. I'm glad these things which fell through the cracks are being caught before 0.7 drops :)
ForLoveOfCats
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This undoes another change from #1107 that I think was a regression.
For example, if I have a horizontal scroll whose child has a finite height, I think that the scroll should inherit that same height. After #1107, the scroll would instead make its height as large as possible.