Split up WindowDesc to allow sub-windows and window reconfiguration.#1235
Split up WindowDesc to allow sub-windows and window reconfiguration.#1235rjwittams merged 1 commit intolinebender:masterfrom
Conversation
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
This looks good to me, a few questions inline but nothing blocking. Thanks!
cmyr
added
S-ready
| self | ||
| } | ||
|
|
||
| /// Set whether the window should be resizable. |
| self | ||
| } | ||
|
|
||
| /// Set whether the window should have a titlebar and decorations. |
| self | ||
| } | ||
|
|
||
| /// Sets the window position in virtual screen coordinates. |
There was a problem hiding this comment.
Maybe mention that some platforms might not honor this.
|
I'll fix some bits later/tomorrow - a lot of the docs are just moved around from WindowDesc, I don't think fixing the content of those docs really has much to do with this PR. Some things are public because they need to be for subwindows I think (which has to construct windows slightly differently from the Druid side - ie not using WindowDesc). |
|
my strategy around |
rjwittams
force-pushed
the
pending-window
branch
from
2867bbd to
f22a375
Compare
4 participants
This is extracted from sub-windows.
It allows reconfiguration of windows and paves the way for construction of non-top level ones.