Skip to content

Create default env with Env::default()#1237

Merged
cmyr merged 1 commit intolinebender:masterfrom
totsteps:env-setup
Sep 18, 2020
Merged

Create default env with Env::default()#1237
cmyr merged 1 commit intolinebender:masterfrom
totsteps:env-setup

Conversation

@totsteps
Copy link
Collaborator

@totsteps totsteps commented Sep 15, 2020

Fixes #1181

cmyr
cmyr requested changes Sep 16, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! have a few little suggestions but this looks like a good bit of cleanup. :)

@luleyleo luleyleo added the S-waiting-on-author waits for changes from the submitter label Sep 16, 2020
@totsteps totsteps requested a review from cmyr September 18, 2020 01:01
cmyr
cmyr approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@cmyr cmyr merged commit 67b52ff into linebender:master Sep 18, 2020
@totsteps totsteps deleted the env-setup branch September 18, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmyr cmyr cmyr approved these changes

Assignees

No one assigned

Labels

S-waiting-on-author waits for changes from the submitter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

env setup is confusing

3 participants

@totsteps @cmyr @luleyleo