Conversation
cmyr
force-pushed
the
arcstr-in-labeltext
branch
from
e101e2b to
5291c12
Compare
cmyr
force-pushed
the
arcstr-in-labeltext
branch
from
5291c12 to
b6e7216
Compare
cmyr
force-pushed
the
arcstr-in-labeltext
branch
from
b6e7216 to
067323c
Compare
This makes label work more like other widgets; the RawLabel widget is a thing that has a text data type (currently ArcStr) and displays this text. The existing Label widget is rewritten as a wrapper around RawLabel; it is basically a sort of specialized, env-aware LensWrap.
luleyleo
approved these changes
Sep 25, 2020
Collaborator
luleyleo
left a comment
luleyleo
left a comment
There was a problem hiding this comment.
It's a bit annoying that we have to duplicate the builder methods, but I suppose there is now good way around it.
cmyr
added a commit
that referenced
this pull request
Sep 27, 2020
We were failing to set the text in the update case; this was a consequence of #1252
cmyr
added a commit
that referenced
this pull request
Sep 27, 2020
We were failing to set the text in the update case; this was a consequence of #1252
cmyr
added a commit
that referenced
this pull request
Sep 27, 2020
This was removed as part of #1252, but I actually use it in runebender so would prefer to keep it around for the time being.
cmyr
added a commit
that referenced
this pull request
Sep 27, 2020
We were failing to set the text in the update case; this was a consequence of #1252
cmyr
added a commit
that referenced
this pull request
Sep 27, 2020
This was removed as part of #1252, but I actually use it in runebender so would prefer to keep it around for the time being.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(based off of #1245)
This makes label work more like other widgets; the RawLabel
widget is a thing that has a text data type (currently ArcStr)
and displays this text.
The existing Label widget is rewritten as a wrapper around
RawLabel; it is basically a sort of specialized, env-aware
LensWrap.