Make dialogs on windows non-sychronous.#1328
Merged
jneem merged 3 commits intolinebender:masterfrom Oct 29, 2020
jneem:windows-async
Merged
Make dialogs on windows non-sychronous.#1328jneem merged 3 commits intolinebender:masterfrom jneem:windows-async
jneem merged 3 commits intolinebender:masterfrom
jneem:windows-async
Conversation
Member
Author
|
@rhzk I got an email notification that you left a comment, but I can't see it now... |
Member
Author
|
Now that mac support has landed, I've updated this PR to remove the backwards-compatibility glue. |
cmyr
approved these changes
Oct 29, 2020
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Great. Looks like there might be some clippy stuff to clean up now, but happy to have this all sorted out, thanks again for taking this on!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does #1068 for windows.