Allow user to specify different min-sizes for each side of a Split.#1370
Merged
cmyr merged 2 commits intolinebender:masterfrom Nov 4, 2020
Merged
Allow user to specify different min-sizes for each side of a Split.#1370cmyr merged 2 commits intolinebender:masterfrom
cmyr merged 2 commits intolinebender:masterfrom
Conversation
Zarenor
approved these changes
Nov 3, 2020
Collaborator
Zarenor
left a comment
Zarenor
left a comment
There was a problem hiding this comment.
Looks straightforward, and like the easy way to do this.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the Split widget only accepts a single "min_size: f64" value which is applied to both halves of the split. In situations where the two child widgets have different min-sizes, the user has no way to specify this, leading to one component being overlarge or the other sometimes forced off the edge of the Split widget. This patch modifies the relevant functions to accept separate min-size values for the two child widgets.