Skip to content

Add MouseButtons.count()#1500

Merged
richard-uk1 merged 3 commits intolinebender:masterfrom
jjl:feature/buttons-count
Jan 5, 2021
Merged

Add MouseButtons.count()#1500
richard-uk1 merged 3 commits intolinebender:masterfrom
jjl:feature/buttons-count

Conversation

@jjl
Copy link
Contributor

@jjl jjl commented Jan 3, 2021

No description provided.

Copy link
Collaborator

@richard-uk1 richard-uk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wonder, does the function have to take a &mut, rather than &?

@jjl
Copy link
Contributor Author

jjl commented Jan 4, 2021

Good spot, sorted.

@richard-uk1
Copy link
Collaborator

Ack, now clippy is complaining because the object is Copy. Would you change it from &self to self, then clippy will be happy.

@jjl
Copy link
Contributor Author

jjl commented Jan 5, 2021

Done. Hazards of thinking your chamge is too small to upset clippy...

@richard-uk1 richard-uk1 merged commit 69a8bcf into linebender:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants