Conversation
rjwittams
approved these changes
Jan 7, 2021
|
I understand the utility in having a rich text example here, but I do get a bit squeamish at the prospect of including a Markdown parser in the bargain. Markdown parsing is one of those things that seems simple at first blush and the ecosystem is cluttered with things that sort of work until they fall on their face. Kind of like Adobe and others insisting on writing their own shapers or people blindly assuming BiDi is easy. Not saying this can't go it, but maybe a comment highlighting the POC nature to be used for the display code not as a starting point for any real Rust based Markdown parsing would be in order. |
Collaborator
|
Do you mean the dev dependency on pulldown-cmark? Or something else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process of writing up a small
0.7.0release post I noticed we didn't really have any example code that demonstrates rich text stuff at all. This adds a simple markdown editor demo that I had sitting around.