Made 'set_level' available from WindowDesc#1515
Merged
cmyr merged 1 commit intolinebender:masterfrom Jan 8, 2021
Merged
Conversation
cmyr
approved these changes
Jan 8, 2021
Member
cmyr
left a comment
There was a problem hiding this comment.
This seems reasonable to me, thanks!
I dont' really like us using the prefix set_ on these methods since it implies mutation and these are builder methods; but these particular methods are all over the place, so I think it's fine for now, and at some point in the future we can do a big 'api consistency' pass and fix this. 🤷
Contributor
Author
|
Thanks! Yea, same. In general i found it confusing as a noob, how the WindowConfig was supposed to be used, or rather why this layer of pass-trough with WindowDesc - hides -> WindowConfig was there. This interface could def. use some reworking when api consistency is looked at. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no simple way of setting the WindowLevel prior to creation for a window.
This would allows tiling window managers like i3 to see the _NET_WM_WINDOW_TYPE_DIALOG flag on window creation
and mark the window as floating.
Since all other options of WindowConfig are exposed in WindowDesc, this seems like an oversight. :)