Skip to content

Made 'set_level' available from WindowDesc#1515

Merged
cmyr merged 1 commit intolinebender:masterfrom
Schaback:expose-setlevel
Jan 8, 2021
Merged

Made 'set_level' available from WindowDesc#1515
cmyr merged 1 commit intolinebender:masterfrom
Schaback:expose-setlevel

Conversation

@Schaback
Copy link
Contributor

@Schaback Schaback commented Jan 8, 2021

There is no simple way of setting the WindowLevel prior to creation for a window.
This would allows tiling window managers like i3 to see the _NET_WM_WINDOW_TYPE_DIALOG flag on window creation
and mark the window as floating.
Since all other options of WindowConfig are exposed in WindowDesc, this seems like an oversight. :)

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, thanks!

I dont' really like us using the prefix set_ on these methods since it implies mutation and these are builder methods; but these particular methods are all over the place, so I think it's fine for now, and at some point in the future we can do a big 'api consistency' pass and fix this. 🤷

@cmyr cmyr merged commit d7a1e39 into linebender:master Jan 8, 2021
@Schaback
Copy link
Contributor Author

Schaback commented Jan 8, 2021

Thanks! Yea, same. In general i found it confusing as a noob, how the WindowConfig was supposed to be used, or rather why this layer of pass-trough with WindowDesc - hides -> WindowConfig was there. This interface could def. use some reworking when api consistency is looked at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants