Allow additional l10n resource in AppLauncher#1528
Merged
cmyr merged 3 commits intolinebender:masterfrom Jan 12, 2021
Merged
Conversation
Collaborator
Author
|
cc @cmyr |
cmyr
reviewed
Jan 11, 2021
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
I think this is the right general idea but I think I'd be less fancy; more details below.
edwin0cheng
force-pushed
the
l10n-resource
branch
from
efafc2a to
2113de9
Compare
edwin0cheng
changed the title
edwin0cheng
force-pushed
the
l10n-resource
branch
from
2113de9 to
dd6ba65
Compare
Collaborator
Author
|
And I refactor out the DEBUG_COLORS in |
cmyr
reviewed
Jan 11, 2021
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Cool I think this looks right, one little comment but overall I'm happy.
Have you verified that this patch lets you do what you need to do?
Collaborator
Author
Yes !
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added
localization_resourceinAppLauncher, which enabled additional resource to use in app.