Conversation
…so the window origin is correct for descendents.
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Looks great. a few little things inline but nothing major. Thanks!
doc fix Co-authored-by: Colin Rofls <colin@cmyr.net>
doc fix Co-authored-by: Colin Rofls <colin@cmyr.net>
doc fix Co-authored-by: Colin Rofls <colin@cmyr.net>
doc fix Co-authored-by: Colin Rofls <colin@cmyr.net>
| - `AppLauncher::localization_resources` to use custom l10n resources. ([#1528] by [@edwin0cheng]) | ||
| - Shell: get_content_insets and mac implementation ([#XXXX] by [@rjwittams]) | ||
| - Contexts: to_window and to_screen (useful for relatively positioning sub windows) ([#XXXX] by [@rjwittams]) | ||
| - WindowSizePolicy: allow windows to be sized by their content ([#XXXX] by [@rjwittams]) |
There was a problem hiding this comment.
@rjwittams might want to pr something to fix these up?
| title: String::new(), | ||
| menu: None, | ||
| size: Size::new(500.0, 400.0), | ||
| size: Size::new(0., 0.), |
There was a problem hiding this comment.
See issue #1543: because of this change, windows don't appear at all on Mac if their size are not explicitly set.
|
@rjwittams I am hitting a mysterious exception thrown in a cocoa paint method that bisect has tracked down to de5f88a. As far as I've tested this only happens on Catalina, although I can reproduce in runebender consistently: run the application, and then open two glyph windows; the app aborts when you try to open the second window. I'm curious to know more about the rationale of the deferring of the size & position setting; that might help me track this down a bit further. |
|
This was deferred in order to avoid reentrancy issues (wrt borrowing the app state I think? Due to the window handler going back into druid). |
3 participants
Expose WindowLevel, add get_content_insets, track widgets window relative coordinates.
Add WindowSizePolicy to allow windows to size themselves to their content.
Make scroll contained things re layout if the scroll offset changes.
All of these are to let subwindows like dropdowns be laid out relative to their parent widget.
The drop down widget itself isn't here. It is currently in nursery locally.