impl Data for a bunch of std types.#1534
Merged
richard-uk1 merged 3 commits intolinebender:masterfrom Jan 14, 2021
Merged
Conversation
maan2003
reviewed
Jan 14, 2021
Collaborator
maan2003
left a comment
maan2003
left a comment
There was a problem hiding this comment.
Looks good to me. But I am not sure about the raw pointers.
druid/src/data.rs
Outdated
Comment on lines
+297
to
+309
| impl<T: 'static + ?Sized> Data for *const T { | ||
| fn same(&self, other: &Self) -> bool { | ||
| // This Does not dereference the pointer, only the reference to the pointer. | ||
| ptr::eq(*self, *other) | ||
| } | ||
| } | ||
|
|
||
| impl<T: 'static + ?Sized> Data for *mut T { | ||
| fn same(&self, other: &Self) -> bool { | ||
| // This Does not dereference the pointer, only the reference to the pointer. | ||
| ptr::eq(*self, *other) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
I would leave these ones. When someone has raw pointers, they are better using same_fn. But if you add these, then also add NonNull
Collaborator
Author
There was a problem hiding this comment.
Hmm OK I'm sold on removing the raw pointers.
Member
There was a problem hiding this comment.
yes I agree I struggle to think of a good case where you'd want this.
The user should handle this themselves safely.
Collaborator
Author
|
I had a look at implementing it for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements
Datafor some more types instd. My motivation wasSystemTime, but I thought I may as well implement it anywhere else it made sense.