Add a CrossAxisAlignment to Flex to fill the available cross space#1551
Merged
cmyr merged 2 commits intolinebender:masterfrom Jan 31, 2021
Merged
Add a CrossAxisAlignment to Flex to fill the available cross space#1551cmyr merged 2 commits intolinebender:masterfrom
cmyr merged 2 commits intolinebender:masterfrom
Conversation
cmyr
approved these changes
Jan 25, 2021
Member
cmyr
left a comment
There was a problem hiding this comment.
This makes sense, and I think it's worth trying, although there are some possible gotchas: for instance the user might expect to be able to use SizedBox::expand here in order to use the available space but that will end up in calculating an infinite size in the first layout pass.
I think it's worth getting this in though and seeing if that ends up being a problem in practice, I can see the real benefit here. :)
Thanks!
Co-authored-by: Colin Rofls <colin@cmyr.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for introducing a new enum value


FilltoFlex'sCrossAxisAlignment.Children with the
Fillcross axis alignment are laid out to fill the entire available cross space, resulting in such layouts:The same layout using
Startlooks like this: