Allowing Container's background and border to be removed.#1558
Merged
cmyr merged 3 commits intolinebender:masterfrom Jan 31, 2021
Merged
Allowing Container's background and border to be removed.#1558cmyr merged 3 commits intolinebender:masterfrom
cmyr merged 3 commits intolinebender:masterfrom
Conversation
tirix
reviewed
Jan 30, 2021
Contributor
tirix
left a comment
tirix
left a comment
There was a problem hiding this comment.
Technically nothing to say!
I only have a remark on the naming.
druid/src/widget/container.rs
Outdated
| } | ||
|
|
||
| /// Removes background. | ||
| pub fn remove_background(&mut self) { |
Contributor
There was a problem hiding this comment.
I'm used to the 'set/clear' and 'add/remove' verbs used in pairs. This would be set/remove, so would the right verb rather be 'clear_background'?
Contributor
Author
There was a problem hiding this comment.
I agree. Made the change.
cmyr
approved these changes
Jan 30, 2021
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
+1, I would go with clear here. otherwise looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1554