Take root widget directly in WindowDesc::new#1559
Merged
cmyr merged 3 commits intolinebender:masterfrom Feb 3, 2021
lassipulkkinen:windowdesc-new-no-closure
Merged
Take root widget directly in WindowDesc::new#1559cmyr merged 3 commits intolinebender:masterfrom lassipulkkinen:windowdesc-new-no-closure
cmyr merged 3 commits intolinebender:masterfrom
lassipulkkinen:windowdesc-new-no-closure
Conversation
Member
|
/bloat |
cmyr
approved these changes
Feb 3, 2021
Member
cmyr
left a comment
There was a problem hiding this comment.
ha funny, I'd forgotten why this API was like this, but I'm pretty sure you're right.
I do think that this is a simplification, and I'm happy to merge, once we figure out what's up with CI.
🗜 Bloat check ⚖️Comparing ef17edd against 4c865b9
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WindowDesc::newcurrently accepts the root widget as a closure that returnsW: Widget<_>, which made sense before the changes in #519. This PR changes that to takeWdirectly instead, as using a closure serves no purpose anymore.EDIT: Sorry for the force push mess; I forgot to
cargo fmt. Also, reverted AUTHORS change on second thought, as this is probably not eligible for copyright.