Skip to content

Ctrl+Backspace delete left word not working in Windows 10#1574

Merged
Ciantic merged 4 commits intolinebender:masterfrom
Ciantic:master
Feb 9, 2021
Merged

Ctrl+Backspace delete left word not working in Windows 10#1574
Ciantic merged 4 commits intolinebender:masterfrom
Ciantic:master

Conversation

@Ciantic
Copy link
Collaborator

@Ciantic Ciantic commented Feb 9, 2021

I tested all CTRL shortcuts #615 and found out that Ctrl+Backspace was not working in Windows 10, turns out that character 7f is ctrl+backspace. This fixes the behavior in Windows 10.

If you search how other have handled the 0x7f, WM_CHAR it seems to be common exception.

Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And yeah, squashing commits is probably cleaner here.

@Ciantic
Copy link
Collaborator Author

Ciantic commented Feb 9, 2021

Ok, I think it could be now merged, I think Github has a button to Merge+Squash, I haven't done githubs pull request too often.

@Ciantic Ciantic merged commit a9e8b01 into linebender:master Feb 9, 2021
richard-uk1 pushed a commit to richard-uk1/druid that referenced this pull request Apr 6, 2021
…#1574)

I tested all CTRL shortcuts linebender#615 and found out that Ctrl+Backspace was not working in Windows 10, turns out that character 7f is ctrl+backspace. This fixes the behavior in Windows 10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants