Ctrl+Backspace delete left word not working in Windows 10#1574
Merged
Ciantic merged 4 commits intolinebender:masterfrom Feb 9, 2021
Merged
Ctrl+Backspace delete left word not working in Windows 10#1574Ciantic merged 4 commits intolinebender:masterfrom
Ciantic merged 4 commits intolinebender:masterfrom
Conversation
raphlinus
reviewed
Feb 9, 2021
raphlinus
approved these changes
Feb 9, 2021
Contributor
raphlinus
left a comment
There was a problem hiding this comment.
Thanks! And yeah, squashing commits is probably cleaner here.
Collaborator
Author
|
Ok, I think it could be now merged, I think Github has a button to Merge+Squash, I haven't done githubs pull request too often. |
richard-uk1
pushed a commit
to richard-uk1/druid
that referenced
this pull request
Apr 6, 2021
…#1574) I tested all CTRL shortcuts linebender#615 and found out that Ctrl+Backspace was not working in Windows 10, turns out that character 7f is ctrl+backspace. This fixes the behavior in Windows 10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested all CTRL shortcuts #615 and found out that Ctrl+Backspace was not working in Windows 10, turns out that character 7f is ctrl+backspace. This fixes the behavior in Windows 10.
If you search how other have handled the 0x7f, WM_CHAR it seems to be common exception.