Skip to content

dont use widgets for padding in flex #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmyr merged 19 commits into from
Feb 18, 2021
Merged

dont use widgets for padding in flex #1584

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1005907
move spacers away from being widget backed
JAicewizard Feb 6, 2021
311719d
small cleanup
JAicewizard Feb 6, 2021
36ce209
other implementation
JAicewizard Feb 8, 2021
ff5d76c
fix??
JAicewizard Feb 9, 2021
90150ed
small performance improvements
JAicewizard Feb 9, 2021
2a17641
undo changes in example
JAicewizard Feb 12, 2021
cc1bd82
undo changes in example
JAicewizard Feb 12, 2021
7bef7dc
undo changes in example
JAicewizard Feb 12, 2021
fc26ba3
fmt
JAicewizard Feb 12, 2021
a2f771e
add changelog
JAicewizard Feb 12, 2021
608721c
mode to struct fields and add `.widget{_mut}` method on flex children
JAicewizard Feb 18, 2021
f769e1d
Merge branch 'master' into non_widget_padding
JAicewizard Feb 18, 2021
a65bd52
Merge branch 'non_widget_padding' of github.com:JAicewizard/druid int…
JAicewizard Feb 18, 2021
cf3288c
fmt
JAicewizard Feb 18, 2021
f8f19c8
_even better_ nice looking stuff
JAicewizard Feb 18, 2021
3f99fcc
Update druid/src/widget/flex.rs
JAicewizard Feb 18, 2021
ae6b549
Update druid/src/widget/flex.rs
JAicewizard Feb 18, 2021
b766811
Update druid/src/widget/flex.rs
JAicewizard Feb 18, 2021
851bd1d
Apply suggestions from code review
cmyr Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ You can find its changes [documented below](#070---2021-01-01).
- Warn on unhandled Commands ([#1533] by [@Maan2003])
- `WindowDesc::new` takes the root widget directly instead of a closure ([#1559] by [@lassipulkkinen])
- Switch to trace-based logging ([#1562] by [@PoignardAzur])
- Spacers in `Flex` are now implemented by calculating the space in `Flex` instead of creating a widget for it ([#1584] by [@JAicewizard])

### Deprecated

Expand Down
Loading