Listiter impl#1641
Merged
cmyr merged 18 commits intolinebender:masterfrom Mar 12, 2021
Lejero:listiter-impl
Merged
Conversation
pull master into branch
Contributor
Author
|
I'm not very familiar with web assembly but I can't get the test to run on my computer. Not sure if there's additional setup I need to do it or possibly its having trouble on an M1-mac which I'm using. |
Collaborator
|
I believe you're missing an entry in (I abandoned a similar PR a while back glad to see this being picked up!) |
Contributor
Author
|
Yes, that was exactly it. I just pushed the change adding to the web examples and all the tests ran successfully. Thanks. |
cmyr
reviewed
Mar 11, 2021
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
A couple little things and then one genuine concern I ran into; take a look and let me know what you think?
cmyr
added
S-waiting-on-author
Co-authored-by: Colin Rofls <colin@cmyr.net>
Co-authored-by: Colin Rofls <colin@cmyr.net>
richard-uk1
pushed a commit
to richard-uk1/druid
that referenced
this pull request
Apr 6, 2021
* adding ListIter implementations and examples * Changed example name, added modifying via buttons. * handling changes of Key for OrdMap and HashMap * Added lejero user, pull request detail * changelog edit * github spelling mistake * change log overwrite * formatting, adhering to standards * adding changelog entry * Added PR * Added web examples entry for list_sources.rs * Removed HashMap ListIter implementation. * Update CHANGELOG.md Co-authored-by: Colin Rofls <colin@cmyr.net> * Update druid/examples/list_sources.rs Co-authored-by: Colin Rofls <colin@cmyr.net> * Removed Unnecessary Clone * Removed HashMap Key and Value impl for ListIter and list_sources.rs example Co-authored-by: Colin Rofls <colin@cmyr.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ListIter implementations for HashMap and OrdMap. Still unsure if handling key modifications the best way, but values should be good. (This is my first PR here)