Skip to content

Add SCROLLBAR_MIN_SIZE to env, and use Entry#1661

Merged
maan2003 merged 12 commits intolinebender:masterfrom
Cupnfish:master
Mar 18, 2021
Merged

Add SCROLLBAR_MIN_SIZE to env, and use Entry#1661
maan2003 merged 12 commits intolinebender:masterfrom
Cupnfish:master

Conversation

@Cupnfish
Copy link
Contributor

No description provided.

Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! just few nitpicks here and there

Cupnfish and others added 4 commits March 18, 2021 13:47
Co-authored-by: Manmeet Maan <49202620+Maan2003@users.noreply.github.com>
Co-authored-by: Manmeet Maan <49202620+Maan2003@users.noreply.github.com>
Co-authored-by: Manmeet Maan <49202620+Maan2003@users.noreply.github.com>
Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more.

It makes sense to move the definition of SCROLLBAR_MIN_SIZE to module theme given that other scrollbar related things are there too. (looks like I can't comment there)

Cupnfish and others added 3 commits March 18, 2021 14:47
Co-authored-by: Manmeet Maan <49202620+Maan2003@users.noreply.github.com>
Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@maan2003 maan2003 merged commit fa156d7 into linebender:master Mar 18, 2021
richard-uk1 pushed a commit to richard-uk1/druid that referenced this pull request Apr 6, 2021
* Add SCROLLBAR_MIN_SIZE to env, and  use Entry

* cargo fmt

* Update druid/src/scroll_component.rs

Co-authored-by: Manmeet Maan <49202620+Maan2003@users.noreply.github.com>

* Update druid/src/env.rs

Co-authored-by: Manmeet Maan <49202620+Maan2003@users.noreply.github.com>

* Update druid/src/env.rs

Co-authored-by: Manmeet Maan <49202620+Maan2003@users.noreply.github.com>

* Some adjustments

* Move SCROLLBAR_MIN_SIZE to module theme

* fmt

Co-authored-by: Manmeet Maan <49202620+Maan2003@users.noreply.github.com>

* cargo fmt

* cargo fmt

* fmt

* Update theme.rs

Co-authored-by: Downtime <40173605+YRainbbbb@users.noreply.github.com>
Co-authored-by: Manmeet Maan <49202620+Maan2003@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants