Adding protections for invalid flex parameters#1691
Merged
cmyr merged 16 commits intolinebender:masterfrom Apr 6, 2021
arthmis:flex_params_safe
Merged
Adding protections for invalid flex parameters#1691cmyr merged 16 commits intolinebender:masterfrom arthmis:flex_params_safe
cmyr merged 16 commits intolinebender:masterfrom
arthmis:flex_params_safe
Conversation
- there is still more work to do to figure out how Flex children use 0.0 flex value
arthmis
changed the title
cmyr
reviewed
Apr 2, 2021
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Thanks! A couple notes inline :)
Collaborator
Author
|
I opted to keep |
cmyr
approved these changes
Apr 4, 2021
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Looks good! A few little formatting nits, but happy to see this merged. :)
josh-audio
added
S-waiting-on-author
Member
|
What's the conclusion here? |
Collaborator
Author
|
In regards to what? Are there any other issues? The only one that came up was the tracing events need a subscriber created before the app is launched but that is a separate issue. oh oops, I'm going to take out the tracing instrument for the add flex child function. I forgot. Other than that I think everything is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, not sure if there are better ways to clamp a value above a certain threshold. Also, is it fine to do the tests like that? I had to do it that way otherwise the test fails in release and passes debug.