GTK Shell: Manually get/set textual data in clipboard#1695
Merged
ForLoveOfCats merged 1 commit intolinebender:masterfrom Apr 7, 2021
Merged
Conversation
ForLoveOfCats
added
shell/gtk
ForLoveOfCats
force-pushed
the
GtkClipboardNewlineNormalizationFix
branch
3 times, most recently
from
6480337 to
a40f334
Compare
ForLoveOfCats
force-pushed
the
GtkClipboardNewlineNormalizationFix
branch
2 times, most recently
from
482b602 to
c51facd
Compare
ForLoveOfCats
force-pushed
the
GtkClipboardNewlineNormalizationFix
branch
from
c51facd to
596f711
Compare
Collaborator
Author
|
Okay so after playing with this some more I realized that the newline chars were being mangled by GTK but only on application shutdown due to some interaction with the clipboard manager. This PR now also manually provides the textual data to the requesting application instead of using GTK's |
ForLoveOfCats
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #981
It seems that newlines were not being mangled on the outbound direction, only on the inbound.By manually retrieving the text and converting to a string we avoid GTK from performing that behavior when getting clipboard contents. This also appears to work on Wayland in both Plasma 5 KWin and Weston.Verification that this behaves correctly on X11 and Wayland would be appreciated :)