Add missing derived lens documentation#1696
Merged
maan2003 merged 7 commits intolinebender:masterfrom Apr 8, 2021
Merged
Conversation
josh-audio
reviewed
Apr 5, 2021
Collaborator
|
Thanks for addressing the comment! I'll have to let someone else approve this PR. I don't know quite enough about derived lenses to know if the wording is accurate. |
maan2003
reviewed
Apr 7, 2021
Co-authored-by: Manmeet Maan <49202620+Maan2003@users.noreply.github.com>
maan2003
reviewed
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you enable
warn(missing_docs)lint when derivingLenson a type, it will detect missing documentation on the#ty_derived_lensesmodule, as well as thefn new()associated function on the lenses. This PR fixes that by adding the missing documentation.