Skip to content

Implement Data for chrono types#1743

Merged
josh-audio merged 2 commits intolinebender:masterfrom
r-ml:chrono-data-impl
Apr 29, 2021
Merged

Implement Data for chrono types#1743
josh-audio merged 2 commits intolinebender:masterfrom
r-ml:chrono-data-impl

Conversation

@r-ml
Copy link
Contributor

@r-ml r-ml commented Apr 27, 2021

Closes #1736

@r-ml r-ml force-pushed the chrono-data-impl branch from 7c377e0 to 4bdd993 Compare April 27, 2021 14:11
@r-ml
Copy link
Contributor Author

r-ml commented Apr 27, 2021

Question: Do we re-export like with the im crate?

@josh-audio josh-audio added the S-needs-review waits for review label Apr 27, 2021
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think there are a few things missing from the changelog, but otherwise this looks good.

@r-ml r-ml force-pushed the chrono-data-impl branch from 4bdd993 to 0f41105 Compare April 28, 2021 18:21
@josh-audio josh-audio added S-ready PR is ready to merge and removed S-needs-review waits for review labels Apr 28, 2021
@josh-audio josh-audio merged commit 8717d0c into linebender:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-ready PR is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Chrono behind feature flag

3 participants