Merged
Conversation
Various common operations were not implemented.
maan2003
reviewed
May 18, 2021
Contributor
Author
|
Alright I made the changes. However it seems like page up and down movement simply isn't implemented in the textbox, but I guess that's fine for now. |
Page up and down now correlate with page up and down movement. Home and End now either move to the start and end of the line or to the start and the end of the document respectively based on whether control is held.
CryZe
force-pushed
the
improve-simulate-input
branch
from
ff5ad0d to
e634685
Compare
josh-audio
added
S-needs-review
Contributor
Author
|
Seems like the CI is trolling me. |
maan2003
added
S-ready
Member
|
Yea pageup/pagedown aren't implemented because they're surprisingly tricky; they don't modify the selection or cursor at all, and are instead handled by the scrollview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various common operations were not implemented. I'm not 100% why these weren't implemented, but I'm assuming this is because the IME work isn't done yet.