Give a WinHandler to the idle callback.#1787
Merged
jneem merged 2 commits intolinebender:masterfrom May 19, 2021
jneem:idle
Merged
Give a WinHandler to the idle callback.#1787jneem merged 2 commits intolinebender:masterfrom jneem:idle
jneem merged 2 commits intolinebender:masterfrom
jneem:idle
Conversation
raphlinus
approved these changes
May 19, 2021
Contributor
raphlinus
left a comment
raphlinus
left a comment
There was a problem hiding this comment.
This seems right to me. I'm the one who did the original dyn Any, but I don't think the justification for that was ever very strong (I wanted to loose coupling so druid-shell wouldn't overly specify the higher levels, but I don't see this change really taking away from that).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I asked about this on zulip and no one replied, so I'm guessing that the reasons for the existing signature of
add_idle_callbackwere lost in the mists of time. It used to be that an idle callback got a&dyn Any, but thatAnyis always just theWinHandler(so,DruidHandlerin alldruidapps). Since&DruidHandlerisn't much use (all the interesting things are&mut), I'm guessing that no one was really using it.