[web backend] Limit max level log to debug and update tracing-wasm#1793
Merged
maan2003 merged 2 commits intolinebender:masterfrom May 19, 2021
Merged
[web backend] Limit max level log to debug and update tracing-wasm#1793maan2003 merged 2 commits intolinebender:masterfrom
maan2003 merged 2 commits intolinebender:masterfrom
Conversation
also need to enable env-filter feature of tracing-subscriber in dev dependencies (needed by test-env-log). tracing-wasm 0.1 enabled env-filter feature. Even though, tracing-wasm was only used on wasm target. It still enabled the env-filter on other targets.
We were logging everything to console, even the trace events. This was a huge performance issue in firefox(keyboard latency of ~1sec in disabled example!)
Collaborator
|
I haven't tested or anything, but this change looks trivial and seems correct. ¯\(ツ)/¯ |
josh-audio
approved these changes
May 19, 2021
josh-audio
added
S-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were logging everything to console, even the trace events. This was a huge performance issue in Firefox(keyboard latency of ~1sec in disabled example!)