x11: Use only a single atom manager#1865
Merged
maan2003 merged 3 commits intolinebender:masterfrom Jul 10, 2021
Merged
Conversation
Atoms are a global resource in X11, so it is unnecessary for every window to query them again. This commit moves the atom manager from Window to Application. Signed-off-by: Uli Schlachter <psychon@znc.in>
There is no point in keeping two separate atom managers around. This commit just merges everything into one and thus avoids one round-trip to the X11 server during startup. Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Uli Schlachter <psychon@znc.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having one atom manager instance per window and another for the clipboard, this merges everything into a single instance. The idea is that this is a tiny, tiny bit more performant (but likely unmeasurable so). Also, constructing the clipboard becomes infallible, which is always nice.