Merged
Conversation
For me hello_web, web and sub_window didn't work see readme.md.
winksaville
force-pushed
the
Fixes-to-examples/readme.md
branch
from
af15d7c to
7eb80f3
Compare
sjoshid
reviewed
Sep 27, 2021
JAicewizard
reviewed
Sep 28, 2021
Contributor
|
Thanks for the contribution! This was a very dragged out pull request, seems like some things slipped through. EDIT: |
On my desktop computer with dual monitors one vertical and one horzitional the "Drag me" window was not always visible on either of my monitors. By removing the call to `set_poistion` the "Drag me" window appears in the middle of the "main window" and is always initially visible.
Fix for rewiew comment by @JAicewizard.
winksaville
commented
Sep 28, 2021
Contributor
Author
winksaville
left a comment
winksaville
left a comment
There was a problem hiding this comment.
What should we do with hello_web and web?
I have no idea why they didn't work for me before, but the are working now. So I'll leave well enough alone :)
Contributor
Author
I retested and they are working now. I've removed the "Not working ..." sentences in readme.md and thing this PR is ready to merge. |
Member
|
@JAicewizard if you're happy with this I'm happy to merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For me hello_web, web and sub_window didn't work see readme.md.