Do not panic in Application::try_global if Application is not created#1996
Merged
maan2003 merged 3 commits intolinebender:masterfrom Oct 3, 2021
Merged
Do not panic in Application::try_global if Application is not created#1996maan2003 merged 3 commits intolinebender:masterfrom
maan2003 merged 3 commits intolinebender:masterfrom
Conversation
maan2003
changed the title
maan2003
changed the title
cmyr
approved these changes
Oct 2, 2021
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
This makes sense, a few little thoughts inline!
`Application::try_global` called `assert_main_thread` but before Application is running the main thread is unclaimed. I think there was no way that `Application::try_global` to return None. Added `assert_main_thread_or_main_unclaimed` that does not panic if main thread is unclaimed.
gtk and mac backends have their own assert_main_thread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application::try_globalcalledassert_main_threadbut before Application is created the main thread is unclaimed.I think there was no way for
Application::try_globalto return None.Added
assert_main_thread_or_main_unclaimedthat does not panic if main thread is unclaimed.Fixes #1995