Allow dynamic LabelText closure to return different types#2064
Merged
maan2003 merged 2 commits intolinebender:masterfrom Dec 3, 2021
jplatte:generic-dynamic-label-text
Merged
Allow dynamic LabelText closure to return different types#2064maan2003 merged 2 commits intolinebender:masterfrom jplatte:generic-dynamic-label-text
maan2003 merged 2 commits intolinebender:masterfrom
jplatte:generic-dynamic-label-text
Conversation
Member
Author
|
CI failure looks unrelated. |
Collaborator
|
rebase should fix CI |
Member
Author
|
Oh, CI failure is related. I'll update the examples tomorrow. |
Contributor
|
I think one downside is that |
Collaborator
This already happens right? We always store data as |
Member
Author
|
Updated the one example affected by this and added a changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should decrease copying (especially if the user-provided closure returns
Arc<str>or something that can be converted to it without copying) and make comparisons inresolvefaster.