wayland: cleanup popup implementation refactor.#2071
wayland: cleanup popup implementation refactor.#2071maan2003 merged 1 commit intolinebender:waylandfrom
Conversation
17c9458 to
0afedd0
Compare
- bunch of other misc cleanups
0afedd0 to
acc004e
Compare
|
I also think this is ready to merge into master! It is pretty close to the x11 backend.
yes should create an issue with
the positioning is exactly same 🤔
we can just update the title/labels for #933 and #936
Yes should create an issue. I think it is for all |
oh? then its really easy. ;) |
- bunch of other misc cleanups
- bunch of other misc cleanups
- bunch of other misc cleanups
only piece I have left at this point is the screen implementation which i need to make some improvements to before I open a PR it.
after that I'll do a rebase against master for the wayland branch. I think at that point it'll be close enough to mainline. PRs after the screen stuff should be minor enhancements, bug fixes (I have 1 or 2 things I might fix), or code cleanup.
still a few small odds an ends to make it feature complete (but i havent needed them so... here we are. =)).
should I create issues for these things?