add start_console_logging(bool) which accepts a flag.#2102
Merged
xStrom merged 1 commit intolinebender:masterfrom Jan 22, 2023
Merged
add start_console_logging(bool) which accepts a flag.#2102xStrom merged 1 commit intolinebender:masterfrom
xStrom merged 1 commit intolinebender:masterfrom
Conversation
xStrom
reviewed
Jan 12, 2023
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Sorry for letting this sit for so long.
Please rebase on master so we can do a fresh CI run and then I'll do a full review.
| - Tabs: allow getting and setting the tab index of a Tabs widget ([#2082] by [@rjwittams] | ||
| - Scope: expose scoped state using state() and state_mut() ([#2082] by [@rjwittams]) | ||
| - Tabs: allow getting and setting the tab index of a Tabs widget ([#2082] by [@rjwittams]) | ||
| - App: add start_console_logging(bool) which accepts a flag. ([#2102] by [@ratmice]) |
Member
There was a problem hiding this comment.
Unfortunately the links aren't automatically generated. Please manually define both [#2102] and [@ratmice] at the bottom of the file.
Contributor
Author
There was a problem hiding this comment.
Rebased and defined the links, sorry I had missed your comment until now.
xStrom
added
S-waiting-on-author
ratmice
force-pushed
the
console_logging_flag
branch
from
a09f8b9 to
41f168e
Compare
xStrom
added
S-needs-review
xStrom
approved these changes
Jan 22, 2023
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Alright, this is simple enough. Let's get it in just in the nick of time.
xStrom
added a commit
to xStrom/druid
that referenced
this pull request
Jan 22, 2023
xStrom
added a commit
to xStrom/druid
that referenced
this pull request
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple patch;
Noticed that when feature gating another logger, it seemed like it would be easier if
log_to_consoletook a bool.Because it occurs in a builder call chain, there doesn't really seem to be a convenient place for
cfgbased conditional compilation.Not really important though