Skip to content

wayland: layershell memoize original display.#2114

Merged
maan2003 merged 3 commits intolinebender:masterfrom
james-lawrence:wayland-layershell-reinitialization
Jan 13, 2022
Merged

wayland: layershell memoize original display.#2114
maan2003 merged 3 commits intolinebender:masterfrom
james-lawrence:wayland-layershell-reinitialization

Conversation

@james-lawrence
Copy link
Contributor

@james-lawrence james-lawrence commented Jan 8, 2022

when displays become unavailable (powered off, sleep, etc) and then
become available again we want to remember which output we were initial
created against so we properly restore to that display.

@james-lawrence james-lawrence force-pushed the wayland-layershell-reinitialization branch from a652ab3 to 5babc96 Compare January 8, 2022 13:25
when displays become unavailable (powered off, sleep, etc) and then
become available again we want to remember which output we were initial
created against so we properly restore to that display.
@james-lawrence james-lawrence force-pushed the wayland-layershell-reinitialization branch from 5babc96 to d032888 Compare January 8, 2022 13:27
@james-lawrence james-lawrence changed the title layershell memoize original display. wayland: layershell memoize original display. Jan 8, 2022
- a couple std::sync::Arc -> std::rc::Rc fixes.
- rename application::ApplicationData -> application::Data.
repeated events on wayland improperly updated the xkb state
for modifiers. if we're processing a repeat event do not update the
state.
@james-lawrence
Copy link
Contributor Author

@maan2003 next pr will likely be my final PR and will remove some additional wlroot isms. allowing non-layershell applications to work on mutter and hopefully some other wayland compositors.

@jplatte
Copy link
Member

jplatte commented Jan 12, 2022

allowing non-layershell applications

I didn't create an issue for this yet but I also couldn't get my app to float on sway with the wayland backend. Is that related?

@james-lawrence
Copy link
Contributor Author

@jplatte mmm unlikely. most likely I just didn't implement that particular aspect. original goal of all this work wasn't 100% perfection but enough that my applications work and stable enough other people can add missing the various pieces I didn't encounter personally.

@james-lawrence
Copy link
Contributor Author

I'll be filing issues around known issues once I get the last PR done and help with bug fixes and pointing people in the right direction for new stuff.

Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maan2003 maan2003 merged commit cb3da65 into linebender:master Jan 13, 2022
@james-lawrence james-lawrence deleted the wayland-layershell-reinitialization branch January 13, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text input behaves as if Shift was constantly pressed on new wayland backend

3 participants