Merged
Conversation
Contributor
|
Could this be used to avoid the full repaint currently performed after each layout pass? |
Member
|
In principle, yes, I think so. It would need some more work though; it won't just happen automatically from this. |
Collaborator
Author
|
The problem is this line. |
added 4 commits
March 2, 2022 19:05
- only call layout when needed
- fix List::layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation of layout for widgets with multiple children. Now these widgets only call
layouton children which need a layout call. Either becauseWidgetPod::requested_layoutis set or because theirBoxConstrainshave changed.