Make Parse work better with floats#2148
Merged
jneem merged 2 commits intolinebender:masterfrom Mar 6, 2022
Merged
Conversation
jneem
requested changes
Mar 6, 2022
Member
jneem
left a comment
jneem
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just one minor typo...
druid/src/widget/parse.rs
Outdated
| Some(ref x) => { | ||
| // Its possible that the current self.state already represents the data value | ||
| // in that case we shouldn't clobber the self.state. This helps deal | ||
| // with types where parse()/to_string() round trips can loose information |
jneem
approved these changes
Mar 6, 2022
xarvic
pushed a commit
to xarvic/druid
that referenced
this pull request
Jul 29, 2022
This PR updates Parse to skip applying the to_string() in the event that the text already parses to the same value as data. This improves the behavior for f32 and any similar types where there is text lost from a parse/to_string round trip.
xarvic
pushed a commit
to xarvic/druid
that referenced
this pull request
Jul 29, 2022
This PR updates Parse to skip applying the to_string() in the event that the text already parses to the same value as data. This improves the behavior for f32 and any similar types where there is text lost from a parse/to_string round trip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using Parse with TextBox that was lens'd to an f32. The editing behavior is odd, starting from a blank text box you can't type 1.5 because when you get to 1. it gets replaced by 1. This happens because round tripping "1." through parse / to_string results in "1".
This PR updates Parse to skip applying the to_string() in the event that the text already parses to the same value as data. This improves the behavior for f32 and any similar types where there is text lost from a parse/to_string round trip.